[FFmpeg-devel] [PATCH] configure: add #include "version.h" to config.h

[James Almer]

On 27/11/13 9:13 PM, Timothy Gu wrote:
> On Nov 27, 2013 3:23 PM, "Michael Niedermayer" <michaelni at gmx.at> wrote:
>>
>> On Wed, Nov 27, 2013 at 08:10:52PM -0300, James Almer wrote:
>>> On 27/11/13 7:45 PM, Michael Niedermayer wrote:
>>>> On Tue, Nov 26, 2013 at 02:43:18PM -0800, Timothy Gu wrote:
>>>>> Avoid clash with version.h of the libraries.
>>>>>
>>>>> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
>>>>> ---
>>>>>  cmdutils.c | 1 -
>>>>>  configure  | 1 +
>>>>>  ffprobe.c  | 1 -
>>>>>  3 files changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> applied
>>>>
>>>> thanks
>>>
>>> Bad secondary effect i just noticed: Every time version.h is changed
>>> (git pull for example), anything that includes config.h will be
>>> recompiled. And that means pretty much every single file in the tree.
>>>
>>> This should probably be reverted. Then we can think on an alternative
>>> solution.
>>
>> agree, reverted :(
>>
>> maybe we could add a ffmpeg_version.h, and include that where needed
> 
> Do you mean changing the file name to ffmpeg_version.h? That seems like the
> best solution now.
> 
> Timothy

I personally prefer ver.h rather than ffmpeg_version.h

And yes, this is probably the best option.