[FFmpeg-devel] [PATCH] configure: add #include "version.h" to config.h

[Michael Niedermayer]

On Wed, Nov 27, 2013 at 08:10:52PM -0300, James Almer wrote:
> On 27/11/13 7:45 PM, Michael Niedermayer wrote:
> > On Tue, Nov 26, 2013 at 02:43:18PM -0800, Timothy Gu wrote:
> >> Avoid clash with version.h of the libraries.
> >>
> >> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
> >> ---
> >>  cmdutils.c | 1 -
> >>  configure  | 1 +
> >>  ffprobe.c  | 1 -
> >>  3 files changed, 1 insertion(+), 2 deletions(-)
> > 
> > applied
> > 
> > thanks
> 
> Bad secondary effect i just noticed: Every time version.h is changed 
> (git pull for example), anything that includes config.h will be 
> recompiled. And that means pretty much every single file in the tree.
> 
> This should probably be reverted. Then we can think on an alternative 
> solution.

agree, reverted :(

maybe we could add a ffmpeg_version.h, and include that where needed

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131128/5ee2ee29/attachment.asc>