[FFmpeg-devel] [PATCH] Remove extensions from MPEG-PS muxers.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Nov 17 13:25:32 CET 2013


When the file-name is .mpg, most users will not want a
"MPEG-1 Systems" that almost all programs will fail to play (at least
as soon as e.g. AC3 is muxed into it).
It is also likely that a user encoding to a file ending in .vob
is trying to encode in a DVD-compatible format.
Either way, since two formats have the same extension, it would
be "random" what the user gets, which certainly is not a good
thing either.

Related to trac issue #1720.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
---
 libavformat/mpegenc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c
index 0a9d69b..3c6cef2 100644
--- a/libavformat/mpegenc.c
+++ b/libavformat/mpegenc.c
@@ -1173,7 +1173,6 @@ AVOutputFormat ff_mpeg1system_muxer = {
     .name              = "mpeg",
     .long_name         = NULL_IF_CONFIG_SMALL("MPEG-1 Systems / MPEG program stream"),
     .mime_type         = "video/mpeg",
-    .extensions        = "mpg,mpeg",
     .priv_data_size    = sizeof(MpegMuxContext),
     .audio_codec       = AV_CODEC_ID_MP2,
     .video_codec       = AV_CODEC_ID_MPEG1VIDEO,
@@ -1204,7 +1203,6 @@ AVOutputFormat ff_mpeg2vob_muxer = {
     .name              = "vob",
     .long_name         = NULL_IF_CONFIG_SMALL("MPEG-2 PS (VOB)"),
     .mime_type         = "video/mpeg",
-    .extensions        = "vob",
     .priv_data_size    = sizeof(MpegMuxContext),
     .audio_codec       = AV_CODEC_ID_MP2,
     .video_codec       = AV_CODEC_ID_MPEG2VIDEO,
@@ -1222,7 +1220,6 @@ AVOutputFormat ff_mpeg2svcd_muxer = {
     .name              = "svcd",
     .long_name         = NULL_IF_CONFIG_SMALL("MPEG-2 PS (SVCD)"),
     .mime_type         = "video/mpeg",
-    .extensions        = "vob",
     .priv_data_size    = sizeof(MpegMuxContext),
     .audio_codec       = AV_CODEC_ID_MP2,
     .video_codec       = AV_CODEC_ID_MPEG2VIDEO,
-- 
1.8.4.3



More information about the ffmpeg-devel mailing list