[FFmpeg-devel] [PATCH] ffprobe: implement string validation policy setting

Stefano Sabatini stefasab at gmail.com
Wed Nov 13 14:39:56 CET 2013


On date Thursday 2013-10-03 10:04:31 +0200, Stefano Sabatini encoded:
> On date Wednesday 2013-10-02 19:07:54 +0200, Clément Bœsch encoded:
[...]
> > Could you add a broken char sequence to tests/test.ffmeta so this code is
> > covered?
> 
> Unfortunately there are too many broken sequences to test.
> 
> Also which UNICODE subsets should be accepted?
> 
> For example:
> http://www.w3.org/TR/REC-xml/#NT-Char
> 
> lists some disallowed characters. Other characters should be avoid in
> specific circumstances, for example CANC, and others are avoided when
> dealing with subtitles (check_utf8 in utils).
> 
> Ideally all these cases should be addressed in the new routine
> av_get_utf8(), on which the new patch relies.
> -- 
> FFmpeg = Free Fabulous Magnificient Peaceless Ecumenical Guide

> From 7774577706b0da0b28b58777908711421db79700 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Wed, 2 Oct 2013 16:22:17 +0200
> Subject: [PATCH] ffprobe: implement string validation policy setting
> 
> This should fix trac tickets #1163, #2502, #2955.
> ---
>  doc/ffprobe.texi |  25 ++++++++++
>  ffprobe.c        | 146 ++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  2 files changed, 164 insertions(+), 7 deletions(-)

Updated, in case someone wants to review it. Patches depend on the
lavu/avstring utf8_decode patch.
-- 
FFmpeg = Foolish & Frenzy Majestic Picky Eretic Gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ffprobe-check-for-errors-and-abort-immediately.patch
Type: text/x-diff
Size: 10101 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131113/bd1ceb04/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ffprobe-implement-string-validation-policy-setting.patch
Type: text/x-diff
Size: 12691 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131113/bd1ceb04/attachment-0001.bin>


More information about the ffmpeg-devel mailing list