[FFmpeg-devel] [PATCH 2/2] avformat/astdec: return max score from probe after fixing probetest missdetections

Michael Niedermayer michaelni at gmx.at
Thu Nov 7 15:01:46 CET 2013


On Thu, Nov 07, 2013 at 08:22:16AM +0100, Reimar Döffinger wrote:
> 
> 
> On 06.11.2013, at 23:59, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> > libavformat/astdec.c |    2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/astdec.c b/libavformat/astdec.c
> > index 12252dc..ddc685a 100644
> > --- a/libavformat/astdec.c
> > +++ b/libavformat/astdec.c
> > @@ -35,7 +35,7 @@ static int ast_probe(AVProbeData *p)
> >         !AV_RB32(p->buf + 16) || AV_RB32(p->buf + 16) > 8*48000)
> >         return 1;
> > 
> > -    return AVPROBE_SCORE_MAX / 3 * 2;
> > +    return AVPROBE_SCORE_MAX;
> 
> Both look ok to me, though personally I feel max score is a bit high for the few things it checks...

applied the first patch

which score should the 2nd return ? anyone any suggestions ?

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131107/edf76f65/attachment.asc>


More information about the ffmpeg-devel mailing list