[FFmpeg-devel] [PATCH] Add additional FFV1 fate tests

[Peter B.]

On 11/06/2013 10:48 PM, Reimar Döffinger wrote:
>> +# Multipass:
>> +fate-ffv1-dec-v3-yuv422p_pass1:  ${CMD = framecrc -i $(DEC_SRC)/ffv1-enc-v3-yuv422p_pass1.avi} fate-ffv1-enc-v3-yuv422p_pass1
>> +fate-ffv1-dec-v3-yuv422p_pass2:  $(CMD = framecrc -i $(DEC_SRC)/ffv1-enc-v3-yuv422p_pass2.avi) fate-ffv1-enc-v3-yuv422p_pass2
> Hm, why is this $( and all others are ${ ?

The reason why pass2 is $() is that it's a leftover from my very first
try, before I changed it to ${}.
According to Makefile docs, $() and ${} are equivalent.
I just decided to use ${} for calls and $() for variables.


> And why does the pass2 encode not use -an but pass1 does?

It's just that's how I usually do 2-pass encoding:
1st pass: Disable audio for faster processing
2nd pass: Process video and audio for the final result

Since the video has no audio anyway, it shouldn't make any difference.


> Not sure any of these is an issue, just trying to double-check what
> might cause the lack of coverage for pass 2,,,

Thanks.
Maybe Michael's right and the LCOV isn't "seeing" some of the execution...


Pb