[FFmpeg-devel] [Bulk] [PATCH] avformat/mxfdec: dont truncate packets

[Michael Niedermayer]

On Tue, Nov 05, 2013 at 07:57:32AM +0000, Tim Nicholson wrote:
> On 24/10/13 20:28, Michael Niedermayer wrote:
> > Fixes Ticket2776
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavformat/mxfdec.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index d0cbeea..59e5c0d 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -2285,7 +2285,6 @@ static int mxf_read_packet_old(AVFormatContext *s, AVPacket *pkt)
> >                                        "KLV for edit unit %i extending into "
> >                                        "next edit unit",
> >                                        mxf->current_edit_unit);
> > -                klv.length = next_ofs - avio_tell(s->pb);
> >              }
> >  
> >              /* check for 8 channels AES3 element */
> > 
> 
> Sorry for a very late review, but I have been snowed under (with a
> project using ffv1 v3 you may be pleased to hear) and after a quick
> glance it didn't feel right and I wanted to delve further.
> 
> We go to the bother of performing a test to trap (an admittdedly
> unusual) case, and then if it happens do not introduce the safety net to
> avoid an error. It would be better to work out why a false positive is
> occuring with the sample and fix that, otherwise we will reintroduce the
> issue this segment of code was trying to fix.
> 
> Does Tomas have a view? the original code to trap the misreading of OP
> Atom was his.

CC-ing tomas

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131105/935969b7/attachment.asc>