[FFmpeg-devel] [Bulk] [PATCH] avformat/mov: only force parsing for video tracks if stss is empty

Tim Nicholson nichot20 at yahoo.com
Tue Nov 5 09:57:00 CET 2013


On 04/11/13 15:22, Hendrik Leppkes wrote:
> Fixes playback of some AAC streams, which are otherwise mangled by the
> parser, and stss is typically only valid for video anyway.

Typically it only has one entry for video too (which is what I assume
you mean by valid/empty), *however* just because something is typical,
is it prudent to asume it will always be the case?

> ---
>  libavformat/mov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 3d20d33..ad8a668 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -1779,7 +1779,7 @@ static int mov_read_stss(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>      if (!entries)
>      {
>          sc->keyframe_absent = 1;
> -        if (!st->need_parsing)
> +        if (!st->need_parsing && st->codec->codec_type == AVMEDIA_TYPE_VIDEO)
>              st->need_parsing = AVSTREAM_PARSE_HEADERS;
>          return 0;
>      }
> 


-- 
Tim


More information about the ffmpeg-devel mailing list