[FFmpeg-devel] [PATCH 1/3] lavd/pulse_audio_enc: implementation of query_codec

[Lukasz M]

On 2 November 2013 13:12, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:

> On 02.11.2013, at 12:42, Lukasz M <lukasz.m.luki at gmail.com> wrote:
> > On 1 November 2013 15:40, Lukasz Marek <lukasz.m.luki at gmail.com> wrote:
> >
> >> Implementation of query_codec callback that allow to
> >> check if specific codec is supported by device.
> >>
> >> Signed-off-by: Lukasz Marek <lukasz.m.luki at gmail.com>
> >> ---
> >> libavdevice/pulse_audio_enc.c |   16 ++++++++++++++++
> >> 1 file changed, 16 insertions(+)
> >>
> >
> > Patch dropped for now.
>
> Just to clarify: I do not object to it if that's the best our API offers.
> Better than no information at all on which formats might work.
> I was just wondering why we have that API, it seems to me like an attempt
> at being complex (also since you can't just ask: which formats are
> supported? But instead have to iterate through them until you find a
> working one) and useless at the same time, or in short: it sucks.


One other option using existing API might be codec_tag. I haven't notice it
earlier. Anyway I don't know what is it for (I don't know what tags are
for) or if it break something when added in device structure.
But still, this cover only codec, not format and stream params. PCM have 1
to 1 format mapping which helps a bit, as far we don't want to use other
codecs that may support more formats.
Checking if format is really supported is another good thing.

I'll try to prepare it and share some results.