[FFmpeg-devel] [PATCH] Rename ffadler to ffhash and expand it using the generic hash API

James Almer jamrial at gmail.com
Tue May 14 09:47:40 CEST 2013


On 14/05/13 4:32 AM, Reimar Döffinger wrote:
> James Almer <jamrial at gmail.com> wrote:
> 
>> On 14/05/13 4:02 AM, Reimar Döffinger wrote:
>>> On Tue, May 14, 2013 at 03:54:23AM -0300, James Almer wrote:
>>>> +    uint8_t res[32];
>>>
>>> From an API standpoint it absolutely would still
>>> need to be checked against av_hash_get_size,
>>> but maybe we should add a max size define to hash.h?
>>
>> Good idea. The tool would automatically support hashes bigger than 
>> 256 bits as soon as they are added to lavu without changing anything
>> here.
>> What name do you suggest for the define?
> 
> AV_HASH_MAX_SIZE maybe?
> With a comment that it is currently the largest size that the get_size function will return, but that it still needs to be checked since we will not consider adding a larger hash an ABI change.

Sounds good.
I'd rather let someone else make that change since I'm not too good 
writing doxy, but in any case i can send a patch for it after this
gets reviewed.

Regards.


More information about the ffmpeg-devel mailing list