[FFmpeg-devel] [PATCH] Add 'drawgrid' video filter

Andrey Utkin andrey.krieger.utkin at gmail.com
Sat May 11 17:16:21 CEST 2013

2013/5/11 Stefano Sabatini <stefasab at gmail.com>:
> I see this code is mostly duplicated from vf_drawbox.c. What about
> defining the code in vf_drawbox.c, so that it can be factorized?

To me, the code does very few work (in both filters). Reusing these
few lines of code is bigger headache than having them duplicated.
BTW i agree with original comment in vf_drawbox.c: "A nice template
for a filter that needs to write in the input frame". Making trivial
example/template to be a reusable library seem over-engineering to me.
Drawgrid without setting a cell size makes a frame around the image,
so it does what drawbox should do. So if we fight for eliminating
spare code, i'd suggest dropping drawbox.

Andrey Utkin

More information about the ffmpeg-devel mailing list