[FFmpeg-devel] [PATCH 1/3] lavu: add ROUNDED_RSHIFT and use it in various places.

Clément Bœsch ubitux at gmail.com
Wed May 8 23:46:00 CEST 2013


On Wed, May 08, 2013 at 05:27:43PM +0200, Michael Niedermayer wrote:
[...]
> > > > > the operation is not a rounded (to nearest) shift but a
> > > > > shift with rounding to +infinity
> > > > > 
> > > > 
> > > > I'm not sure to understand; are you suggesting a macro rename? Not using
> > > > it in that particular place?
> > > 
> > > i meant a rename yes
> > > 
> > > we have other macros like ROUNDED_DIV that round to nearest
> > > also round() rounds to nearest
> > > 
> > 
> > Please pick one or suggest another:
> >   FF_INFRND_RSHIFT()
> >   FF_RNDINF_RSHIFT()
> >   FF_ROUNDINF_RSHIFT()
> >   FF_ROUNDED_INF_RSHIFT()
> >   FF_RSHIFT_INFRND()
> >   FF_RND_INF_R_SHFT
> >   FF_ALIGN_RSHIFT
> >   FF_RSHIFT_ALIGN
> >   FF_YELLOW_PINK()
> >   FF_RIGHT_SHIFT_ROUNDED_TOWARD_INFINITY()
> 
> iam fine with any that the people like
> 

I'll go for FF_SHIFTUP() unless there is an objection. Will update the
patchset and push in a day or two.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130508/97070949/attachment.asc>


More information about the ffmpeg-devel mailing list