[FFmpeg-devel] [PATCH] fate: make metadata fate tests only output ts and metadata.

[Clément Bœsch]

On Wed, Mar 20, 2013 at 12:01:51AM +0100, Stefano Sabatini wrote:
> On date Tuesday 2013-03-19 23:12:12 +0100, Clément Bœsch encoded:
> > The other information are just cluttering the output.
> > ---
> >  tests/fate/filter.mak                        |    5 +-
> >  tests/ref/fate/filter-metadata-scenedetect   |   20 +-
> >  tests/ref/fate/filter-metadata-silencedetect | 1024 +++++++++++++-------------
> >  3 files changed, 524 insertions(+), 525 deletions(-)
> > 
> > diff --git a/tests/fate/filter.mak b/tests/fate/filter.mak
> > index 761b315..8f1caaa 100644
> > --- a/tests/fate/filter.mak
> > +++ b/tests/fate/filter.mak
> > @@ -60,8 +60,7 @@ FATE_SAMPLES_AVCONV += $(FATE_FILTER-yes)
> >  #
> >  # Metadata tests
> >  #
> > -FILTER_METADATA_COMMAND = ffprobe$(EXESUF) -show_frames -of compact=nk=1:p=0 -bitexact -f lavfi
> > -FILTER_METADATA_COMMAND2 = ffprobe$(EXESUF) -show_frames -of compact=p=0 -show_entries frame=pkt_pts,metadata -bitexact -f lavfi
> > +FILTER_METADATA_COMMAND = ffprobe$(EXESUF) -show_frames -of compact=p=0 -show_entries frame=pkt_pts,metadata -bitexact -f lavfi
> 
> metadata is not even the name of a section (ffprobe -sections).
> 
> ffprobe$(EXESUF) -show_frames -of compact=p=0 -show_entries frame=pkt_pts:frame_tags
> 

Changed/fixed.

> is probably more correct. compact=nk=1:p=0 should be also acceptable
> if you want to save bits.
> 

Printing the metadata keys isn't a bad idea for the tests imo.

> [...]
> > +pkt_pts=161600|tag:lavfi.silence_start=10
> > +pkt_pts=161920
> > +pkt_pts=162240
> > +pkt_pts=162560
> > +pkt_pts=162880
> > +pkt_pts=163200
> > +pkt_pts=163520
> 
> Should be good otherwise.

Will push soon, thanks.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130320/24b868d7/attachment.asc>