[FFmpeg-devel] [PATCH] lavd/lavfi: free buffers requested for pts probing

[Nicolas George]

Le duodi 22 ventôse, an CCXXI, Hendrik Leppkes a écrit :
> Fixing lavd is one thing, but can we be sure no user-code uses the
> peek flag and will run into the same issue? This was my biggest
> concern with the peek flag, and i was truely hoping lavd had just
> forgotten to free it.

I looked on Google and found no results for AV_BUFFERSINK_FLAG_PEEK except
inside ffmpeg itself.

> If the compat API is supposed to be reliable, it somehow needs to
> cover this, but as you say, i'm not sure it'll be easy.

I do not think it would be complicated, but it would require inserting code
in several places that are not at all related to the compat layer.

> Considering this special case of the peek flag not incrementing the
> ref wasn't documented (at least not anywhere i could find it), maybe
> we can somehow wiggle out of this problem?

I like that idea.

In the meantime, I suppose you saw my patch to fix lavd/lavfi; and this
thread can work as a response to your private mail.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130312/cc9362d5/attachment.asc>