[FFmpeg-devel] [PATCH] ffprobe: Stash and use width and height before opening the codec

[Michael Niedermayer]

On Wed, Mar 06, 2013 at 10:52:34PM -0500, Derek Buitenhuis wrote:
> On 2013-03-06 8:58 PM, Michael Niedermayer wrote:
> > -    if (!( avctx->coded_width && avctx->coded_height && avctx->width && avctx->height && avctx->codec_id == AV_CODEC_ID_H264)){
> > +    if (!( avctx->coded_width && avctx->coded_height && avctx->width && avctx->height &&
> > +           (avctx->codec_id == AV_CODEC_ID_H264 || avctx->codec_id == AV_CODEC_ID_VP6F))){
> 
> I dislike this. This is a codec specific hack which could be handled
> generically in ffprobe.c...

ffprobe is the only application affected by this ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130307/19c8aa72/attachment.asc>