[FFmpeg-devel] [PATCH]Fix iconv detection on broken installations (macports)

[Clément Bœsch]

On Mon, Mar 04, 2013 at 08:44:10AM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> I did not test but I suspect "./configure --enable-iconv" succeeds on osx with 
> macports but fails compilation.
> 
> Untested patch attached.
> 
> Please comment, Carl Eugen

> diff --git a/configure b/configure
> index 98cef18..f677a1a 100755
> --- a/configure
> +++ b/configure
> @@ -3874,7 +3874,6 @@ enabled avisynth   && require2 vfw32 "windows.h vfw.h" AVIFileInit -lavifil32
>  enabled fontconfig && require_pkg_config fontconfig "fontconfig/fontconfig.h" FcInit
>  enabled frei0r     && { check_header frei0r.h || die "ERROR: frei0r.h header not found"; }
>  enabled gnutls     && require_pkg_config gnutls gnutls/gnutls.h gnutls_global_init
> -enabled iconv      && { check_func_headers iconv.h iconv || check_lib2 iconv.h iconv -liconv || die "ERROR: iconv not found"; }
>  enabled libiec61883 && require libiec61883 libiec61883/iec61883.h iec61883_cmp_connect -lraw1394 -lavc1394 -lrom1394 -liec61883
>  enabled libaacplus && require  "libaacplus >= 2.0.0" aacplus.h aacplusEncOpen -laacplus
>  enabled libass     && require_pkg_config libass ass/ass.h ass_library_init
> @@ -4039,6 +4038,9 @@ enabled vdpau &&
>      check_cpp_condition vdpau/vdpau.h "defined VDP_DECODER_PROFILE_MPEG4_PART2_ASP" ||
>      disable vdpau
>  
> +# Funny iconv installations are not unusual, so check it after all flags have been set
> +enabled iconv && { check_func_headers iconv.h iconv || check_lib2 iconv.h iconv -liconv || die "ERROR: iconv not found"; }
> +

Are you sure our configure keeps track of all the previous ld flags for
standalone tests?

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130304/4aa9aeed/attachment.asc>