[FFmpeg-devel] [PATCH] build: disable iconv by default.

[Clément Bœsch]

On Mon, Mar 04, 2013 at 12:14:21AM -0300, James Almer wrote:
> On 03/03/13 7:51 PM, Clément Bœsch wrote:
> > On Sun, Mar 03, 2013 at 11:45:06PM +0100, Michael Niedermayer wrote:
> >> On Sun, Mar 03, 2013 at 10:49:22PM +0100, Clément Bœsch wrote:
> >>> It seems to break a lot on MacOS because of a mixup between multiple
> >>> iconv libraries. The issue is that the configure check link with no
> >>> particular library path (so it uses /usr/lib/libiconv.dylib where all
> >>> the symbols are defined). OTOH, the final build might link with extra
> >>> library paths, such as the ports lib directory (typically you get
> >>> -L/opt/local/lib because of an extra library such as SDL). Whatever this
> >>> option position (before or after -liconv), it will try to link with
> >>> /opt/local/lib/libiconv.dylib, and the issue is that this version has
> >>> the same symbols as the ones in /usr/lib/libiconv.dylib except that they
> >>> all start with 'lib' (libiconv_open, libiconv_close, ...). I don't plan
> >>> to try to workaround this mess, so any better solution is welcome.
> >>> ---
> >>>  configure | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> LGTM
> >>
> > 
> > Pushed.
> 
> You forgot to change the corresponding line in the output of ./configure --help 
> from [autodetect] to [no].
> Sorry for not noticing this before you pushed.
> 

Fixed, thanks.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130304/de425055/attachment.asc>