[FFmpeg-devel] [PATCH 2/2 v2] delogo: Take SAR into account

[Stefano Sabatini]

On date Friday 2013-06-28 10:21:23 +0200, Jean Delvare encoded:
[...]
> > >  #define LIBAVFILTER_VERSION_MAJOR  3
> > >  #define LIBAVFILTER_VERSION_MINOR  77
> > > -#define LIBAVFILTER_VERSION_MICRO 101
> > > +#define LIBAVFILTER_VERSION_MICRO 102
> > 
> > No need to bump version for this.
> 
> I received contradicting instructions regarding this on #ffmpeg, from
> "bump it always" to "bump it on interface change only", to "bump it on
> user-visible changes", to "bump it in the last patch of the series." I
> guess I'll just leave it alone from now on and let whoever applies my
> patches bump it when he/she thinks it is appropriate. This makes my life
> easier anyway.

My advice is "bump micro for user-visible changes" in case the other
version numbers are unchanged, tipically when adding a private options
which is not a public symbol (and thus requires no minor bump), but it
might be useful to check (for example we had reports with an user
claiming that an option was not recognized, checking the version
number helps to spot the problem). Also in some cases an API user
might want to check the version number to see if an option is
available.

Usually bug-fixes don't require a micro bump.

> 
> BTW, as I am now very familiar with the delogo filter code, would it be
> desirable that I become the maintainer of it? I don't want to step on
> anyone toes, only wondering if this would be appreciated to off-load
> some work from the core ffmpeg developers. Note though that I do not
> intend to become a full time contributor to ffmpeg (I would love to but
> it simply doesn't fit in my daily job and family life makes my spare
> time a scarce resource) and I am not reading ffmpeg-devel all the time.

Please send a patch to add yourself to MAINTAINERS, with the options
to be put in CC in case of patches affecting delogo. Maintainance work
on a specific component should not require too much time, and is
always welcome.

> Also note that I have several patches in the works for the delogo
> filter, including bug fixes and code optimizations. I'll send them over
> for review when I am done polishing them.
-- 
FFmpeg = Faithful and Fostering Multimedia Power Elegant Gnome