[FFmpeg-devel] [PATCH] lavc: make invalid UTF-8 in subtitle output a non-fatal error

[Nicolas George]

Le decadi 10 messidor, an CCXXI, wm4 a écrit :
> libass has no problem with invalid UTF-8, although I don't remember how
> exactly it handles this situation.

You can not expect to always be so lucky. And the correct wording would not
be "has no problem with" but "implements workarounds for".

> It's possible that an error concealment method could output valid
> UTF-8, though. But completely dropping the event is not nice.

As I said to Reimar, error concealment would probably be a good idea, but
that was absolutely not what you proposed. Error concealment would fit
around the iconv call, checking for EILSEQ and inserting a placeholder
character.

Also, error concealment is only acceptable if the decoding parameters are
correct and the subtitles are actually broken. You did not show that you had
such a file.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130628/66fc2272/attachment.asc>