[FFmpeg-devel] [PATCH] lavc: make invalid UTF-8 in subtitle output a non-fatal error

Nicolas George nicolas.george at normalesup.org
Fri Jun 28 10:52:12 CEST 2013

Le decadi 10 messidor, an CCXXI, Reimar Döffinger a écrit :
> For both audio and video we do not fail with an error by default but
> instead try to run e.g. error concealment. The subtitle code really is the
> odd one here that does not behave in a way consistent with the other code.

The apparent inconsistency comes from the fact that we are talking about a
completely different problem here.

Correct me if I am wrong, but error concealment is for when the input data
is damaged, not for data that was YUV but decoded as RGB. If the input data
is damaged, there is indeed nothing better to do than concealing the error
as nicely possible, there is no -please_magically_fix_my_data option.

For subtitles, the issue is completely different: decoding fail because the
application neglected to add the "-sub_charenc KOI8R" option.

> Note that e.g. MPlayer does kind of error concealment for subtitles,
> replacing invalid characters by a special symbol.

I have no objection to that kind of approach, assuming -sub_charenc was set
(i.e. the subtitles text is actually broken), but wm4's approach has nothing
to do with that.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130628/4451322d/attachment.asc>

More information about the ffmpeg-devel mailing list