[FFmpeg-devel] [PATCH] lavf/mux: try to improve error feedback in case of incompatible tag

[Michael Niedermayer]

On Wed, Jun 26, 2013 at 05:41:28PM +0200, Stefano Sabatini wrote:
> ---
>  libavformat/mux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/mux.c b/libavformat/mux.c
> index 82b5a8e..7099d98 100644
> --- a/libavformat/mux.c
> +++ b/libavformat/mux.c
> @@ -305,8 +305,8 @@ static int init_muxer(AVFormatContext *s, AVDictionary **options)
>                      av_get_codec_tag_string(tagbuf, sizeof(tagbuf), codec->codec_tag);
>                      av_get_codec_tag_string(tagbuf2, sizeof(tagbuf2), av_codec_get_tag(s->oformat->codec_tag, codec->codec_id));
>                      av_log(s, AV_LOG_ERROR,
> -                           "Tag %s/0x%08x incompatible with output codec id '%d' (%s)\n",
> -                           tagbuf, codec->codec_tag, codec->codec_id, tagbuf2);
> +                           "Tag %s/0x%08x incompatible with output codec %s with id %d, correct tag is %s\n",

> +                           tagbuf, codec->codec_tag, avcodec_get_name(codec->codec_id), codec->codec_id, tagbuf2);


I think tagbuf2 can be empty or non unique


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130626/4b92f918/attachment.asc>