[FFmpeg-devel] [PATCH] h264: expose stereo_mode from h264 frame packing info

[Kieran Kunhya]

On Sun, Jun 23, 2013 at 2:24 PM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> On Sun, Jun 23, 2013 at 3:19 PM, Joakim Plate <elupus at ecce.se> wrote:
>> ---
>>  libavcodec/avcodec.h     |  6 ++++
>>  libavcodec/h264.c        |  1 +
>>  libavcodec/h264.h        | 27 +++++++++++++++-
>>  libavcodec/h264_parser.c |  3 ++
>>  libavcodec/h264_sei.c    | 81 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  5 files changed, 117 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>> index 455f57b..1576524 100644
>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -2874,6 +2874,12 @@ typedef struct AVCodecContext {
>>  #define FF_SUB_CHARENC_MODE_AUTOMATIC    0  ///< libavcodec will select the mode itself
>>  #define FF_SUB_CHARENC_MODE_PRE_DECODER  1  ///< the AVPacket data needs to be recoded to UTF-8 before being fed to the decoder, requires iconv
>>
>> +    /**
>> +     * Stereoscopic mode of video (see matroska spec for definition)
>> +     * - decoding: set by libavcodec
>> +     * - encoding: unused
>> +     */
>> +    const char *stereo_mode;
>>  } AVCodecContext;
>
> String constants are really not a great idea in such a public header,
> especially if all they do is reference to some other spec.

It should be per-frame data too imho