[FFmpeg-devel] [PATCH] lavfi/mp: remove some pp filters.

Clément Bœsch ubitux at gmail.com
Fri Jun 14 01:48:47 CEST 2013

 - fspp seems to be a 1d version of spp; users seem to prefer spp
   (denouncement: michaelni, iive, microchip).
 - pp7 is a special version of spp, it might be worth including it in
   the native spp at some point.
 - uspp is a slow and less effective spp

The use-cases of such filters being relatively limited nowadays, it
doesn't seem worth keeping all those pp filters; spp and all the
libpostproc filters should be enough, and optimizations can be added
later if that's really necessary.
 doc/filters.texi                  |    3 -
 libavfilter/Makefile              |    3 -
 libavfilter/libmpcodecs/vf_fspp.c | 2118 -------------------------------------
 libavfilter/libmpcodecs/vf_pp7.c  |  491 ---------
 libavfilter/libmpcodecs/vf_uspp.c |  393 -------
 libavfilter/vf_mp.c               |    6 -
 6 files changed, 3014 deletions(-)
 delete mode 100644 libavfilter/libmpcodecs/vf_fspp.c
 delete mode 100644 libavfilter/libmpcodecs/vf_pp7.c
 delete mode 100644 libavfilter/libmpcodecs/vf_uspp.c

diff --git a/doc/filters.texi b/doc/filters.texi
index 0381c6a..6617094 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -4924,15 +4924,12 @@ The list of the currently supported filters follows:
 @item eq2
 @item eq
 @item fil
- at item fspp
 @item ilpack
 @item perspective
 @item phase
- at item pp7
 @item pullup
 @item qp
 @item softpulldown
- at item uspp
 @end table
 The parameter syntax and behavior for the listed filters are the same
diff --git a/libavfilter/Makefile b/libavfilter/Makefile
index 535ffb8..6a876df 100644
--- a/libavfilter/Makefile
+++ b/libavfilter/Makefile
@@ -222,15 +222,12 @@ OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_dint.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_eq2.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_eq.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_fil.o
-OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_fspp.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_ilpack.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_perspective.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_phase.o
-OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_pp7.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_pullup.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_qp.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_softpulldown.o
-OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/vf_uspp.o
 OBJS-$(CONFIG_MP_FILTER) += libmpcodecs/pullup.o
 # multimedia filters
diff --git a/libavfilter/libmpcodecs/vf_fspp.c b/libavfilter/libmpcodecs/vf_fspp.c
deleted file mode 100644
index a8a33e2..0000000
diff --git a/libavfilter/libmpcodecs/vf_pp7.c b/libavfilter/libmpcodecs/vf_pp7.c
deleted file mode 100644
index 30f9530..0000000
diff --git a/libavfilter/libmpcodecs/vf_uspp.c b/libavfilter/libmpcodecs/vf_uspp.c
deleted file mode 100644
index 54cc0f9..0000000
diff --git a/libavfilter/vf_mp.c b/libavfilter/vf_mp.c
index 3cf22f8..94f3976 100644
--- a/libavfilter/vf_mp.c
+++ b/libavfilter/vf_mp.c
@@ -127,15 +127,12 @@ extern const vf_info_t ff_vf_info_dint;
 extern const vf_info_t ff_vf_info_eq2;
 extern const vf_info_t ff_vf_info_eq;
 extern const vf_info_t ff_vf_info_fil;
-extern const vf_info_t ff_vf_info_fspp;
 extern const vf_info_t ff_vf_info_ilpack;
 extern const vf_info_t ff_vf_info_perspective;
 extern const vf_info_t ff_vf_info_phase;
-extern const vf_info_t ff_vf_info_pp7;
 extern const vf_info_t ff_vf_info_pullup;
 extern const vf_info_t ff_vf_info_qp;
 extern const vf_info_t ff_vf_info_softpulldown;
-extern const vf_info_t ff_vf_info_uspp;
 static const vf_info_t* const filters[]={
@@ -143,15 +140,12 @@ static const vf_info_t* const filters[]={
-    &ff_vf_info_fspp,
-    &ff_vf_info_pp7,
-    &ff_vf_info_uspp,

More information about the ffmpeg-devel mailing list