[FFmpeg-devel] [PATCH] lavu/hmac: Add support for SHA-2

Michael Niedermayer michaelni at gmx.at
Mon Jun 10 18:31:42 CEST 2013


On Sun, Jun 09, 2013 at 04:28:18PM -0300, James Almer wrote:
> Includes HMAC-SHA-224, HMAC-SHA-256, HMAC-SHA-384, and HMAC-SHA-512.
> Tested using test vectors from https://tools.ietf.org/html/rfc4231
[...]
> diff --git a/libavutil/hmac.h b/libavutil/hmac.h
> index aef84c6..ca4da6a 100644
> --- a/libavutil/hmac.h
> +++ b/libavutil/hmac.h
> @@ -32,6 +32,10 @@
>  enum AVHMACType {
>      AV_HMAC_MD5,
>      AV_HMAC_SHA1,
> +    AV_HMAC_SHA224,
> +    AV_HMAC_SHA256,
> +    AV_HMAC_SHA384,
> +    AV_HMAC_SHA512,
>  };

using enums that are a bit higher would avoid possibly future
conflicts with the fork

also a fate test should be added (possibly in a seperate patch)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130610/f7b5ea4b/attachment.asc>


More information about the ffmpeg-devel mailing list