[FFmpeg-devel] [PATCH] doc/encoders: Add libtwolame doc

[Stefano Sabatini]

On date Saturday 2013-06-01 10:41:45 -0700, Timothy Gu encoded:
> ---
>  doc/encoders.texi | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
> 
> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index 6bf9280..8aabb5d 100644
> --- a/doc/encoders.texi
> +++ b/doc/encoders.texi
> @@ -441,6 +441,69 @@ Enables the encoder to use (on a frame by frame basis) either L/R
>  stereo or mid/side stereo.
>  @end multitable
>  
> + at section libtwolame
> +
> +TwoLAME MP2 encoder wrapper
> +
> +Requires the presence of the libtwolame headers and library during
> +configuration. You need to explicitly configure the build with
> + at code{--enable-libtwolame}.
> +
> + at subsection Options Mapping
> +

> +The following options are supported by the libtwolame wrapper. The
> +FFmpeg options are in quotation marks, while the TwoLAME options are

I still object to "in quotation marks" since it really depends on the
rendering engine and is confusing when reading the texi source. On the
other hand, this is a minor remark which can be addressed later and
should not block the patch.

> +in parentheses.
> +
> + at table @option
> + at item b
> +(b) Set bitrate in bits/s. Note that FFmpeg @code{b} option is
> +expressed in bits/s, twolame @code{b} in kilobits/s. (The default
> +value is 128k.)

Nit+: no need for the parentheses

[...]

LGTM, thanks.
-- 
FFmpeg = Freak Funny Minimal Puritan Erroneous Gargoyle