[FFmpeg-devel] [PATCH] lavc/avpacket: fill padding area on side data split.

Clément Bœsch ubitux at gmail.com
Sat Jun 1 15:13:34 CEST 2013


On Sat, Jun 01, 2013 at 02:46:32PM +0200, Michael Niedermayer wrote:
[...]
> > From e05a63d6a48f06639e2002a5c615528a7a7fb8b6 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <ubitux at gmail.com>
> > Date: Sat, 1 Jun 2013 14:07:24 +0200
> > Subject: [PATCH] lavc/avpacket: fill padding area on side data split.
> > 
> > The padding data is assumed to be 0 in several places, notably in
> > subtitles. This problem was not detected with fate-sub-srt test because
> > the first element of the side data (x1) is 0 in the test, so the
> > trailing side data present in the packet wasn't read by the decoder. The
> > issue can be observed with a large enough x1.
> > 
> > It is also noted in FF_INPUT_BUFFER_PADDING_SIZE doxy that MPEG
> > bitstreams require that padding with 0, so it might fix other issues.
> > ---
> >  libavcodec/avpacket.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> LGTM
> 

Applied, thanks.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130601/b171ca99/attachment.asc>


More information about the ffmpeg-devel mailing list