[FFmpeg-devel] [PATCH] avfilter/af_compand: %f is for printing doubles

Michael Niedermayer michaelni at gmx.at
Tue Jul 30 22:30:01 CEST 2013


On Tue, Jul 30, 2013 at 07:19:28PM +0000, Paul B Mahol wrote:
> On 7/30/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Jul 30, 2013 at 06:39:29PM +0000, Paul B Mahol wrote:
> >> On 7/30/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >> > ---
> >> >  libavfilter/af_compand.c |    2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/libavfilter/af_compand.c b/libavfilter/af_compand.c
> >> > index 8630cda..6cbfbf4 100644
> >> > --- a/libavfilter/af_compand.c
> >> > +++ b/libavfilter/af_compand.c
> >> > @@ -355,7 +355,7 @@ static int config_output(AVFilterLink *outlink)
> >> >              return AVERROR(EINVAL);
> >> >          }
> >> >          S(i).y -= S(i).x;
> >> > -        av_log(ctx, AV_LOG_DEBUG, "%d: x=%lf y=%lf\n", i, S(i).x,
> >> > S(i).y);
> >> > +        av_log(ctx, AV_LOG_DEBUG, "%d: x=%f y=%f\n", i, S(i).x,
> >> > S(i).y);
> >> >          new_nb_items++;
> >> >      }
> >> >      num = new_nb_items;
> >> > --
> >> > 1.7.9.5
> >>
> >> This gives me warning with clang.
> >
> > which clang version?
> > which warning?
> > (no warning with clang here)
> 
> Hmm, warning is gone. You can apply.

aplied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130730/f5419230/attachment.asc>


More information about the ffmpeg-devel mailing list