[FFmpeg-devel] [RFC] GXF Patches - HD

Michael Niedermayer michaelni at gmx.at
Thu Jul 25 22:13:16 CEST 2013


On Thu, Jul 25, 2013 at 01:49:04AM -0500, Reuben Martin wrote:
> On Saturday, July 20, 2013 11:43:59 PM Michael Niedermayer wrote:
> > On Mon, Jun 17, 2013 at 03:24:21PM -0500, Reuben Martin wrote:
> > > DV Aux Data & Test Updates
> > > 
> > >  gxfenc.c |   58
> > >  ++++++++++++++++++++++++++++++++++++++++++----------------
> > >  1 file changed, 42 insertions(+), 16 deletions(-)
> > > 
> > > cb589732dfe15d1c25e8ebfd9ad43ca752ab6d9f  03-GXF_DV-aux-data.patch
> > > From d3fe02926248361d322768621ac927b63ac8b9e8 Mon Sep 17 00:00:00 2001
> > > From: Reuben Martin <reuben.m at gmail.com>
> > > Date: Wed, 12 Jun 2013 23:17:21 -0500
> > > Subject: [PATCH 3/8] Added support for writing correct auxiliary data for
> > > DV> 
> > >  streams. Different aux data is written for DVCAM and DVPRO formats.
> > 
> > does this patch fix some testcase / ticket ?
> > or said differently how can the fix be checked ?
> > 
> 
> Sorry for the delay, I've been on vacation the past 2 weeks.
> 
> I'm basing this off of SMPTE 360-2009, clause 7.1.3.2.
> 
> It also states that anything that is not marked DVCAM (yuv420p) is to be 
> assumed DVCPRO.
> 
> I've been checking this against Grass Valley's GXF parser and checker tool: 
> http://www.gvgdevelopers.com/concrete/products/k2/tstream___gxf_file_parser_and_checker/
> 
> It's a little DOS based CLI app that can run under wine.
> 
> The text output from its parser has confirmed in my testing that the patches 
> are working correctly.

patch applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130725/a09dd0d6/attachment.asc>


More information about the ffmpeg-devel mailing list