[FFmpeg-devel] [PATCH] lavfi/delogo: Fix sign extension issue

[Jean Delvare]

Coverity complains about a possible sign extension issue in
apply_delogo(). While it is extremely unlikely to happen, it is easy
to fix so let's just do that. Using unsigned variables even makes the
binary code smaller.

Fixes Coverity CID 1046439.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
---
 libavfilter/vf_delogo.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--- ffmpeg.orig/libavfilter/vf_delogo.c	2013-07-13 16:39:46.961860230 +0200
+++ ffmpeg/libavfilter/vf_delogo.c	2013-07-13 16:49:03.961733592 +0200
@@ -58,9 +58,9 @@ static void apply_delogo(uint8_t *dst, i
                          uint8_t *src, int src_linesize,
                          int w, int h, AVRational sar,
                          int logo_x, int logo_y, int logo_w, int logo_h,
-                         int band, int show, int direct)
+                         unsigned int band, int show, int direct)
 {
-    int x, y, dist;
+    int x, y;
     uint64_t interp, weightl, weightr, weightt, weightb;
     uint8_t *xdst, *xsrc;
 
@@ -125,7 +125,8 @@ static void apply_delogo(uint8_t *dst, i
                 x >= logo_x+band && x < logo_x+logo_w-band) {
                 *xdst = interp;
             } else {
-                dist = 0;
+                unsigned dist = 0;
+
                 if      (x < logo_x+band)
                     dist = FFMAX(dist, logo_x-x+band);
                 else if (x >= logo_x+logo_w-band)

-- 
Jean Delvare