[FFmpeg-devel] [PATCH]Avoid an assertion failure in ff_init_vlc_sparse

[Derek Buitenhuis]

On 7/12/2013 7:37 PM, Carl Eugen Hoyos wrote:
> In case your mail wasn't ironic:
> While I don't agree that an assert is wrong here 
> (that is how I interpret your mail)

Removing an assert and replacing it with an if statement
means one of two things:

1) The original assert was erroneously used for something
   that an assert is not supposed to be used for.
2) The change is wrong.

Your patch did not provide enough surrounding context or
descirption to support #1.

If #2 is true, then by root cause, it means fixing it so that
the assert cannot be tripped... which is how asserts are *supposed*
to be used. It seems #1 is the case though, when I looked at the
whole file.

As a side note, any such confusion could have been avoided
if you actually:

1) Properly git format-patch'd like you're supposed to.
2) Provided a actual explanation for the change, preferably
   as a commit message

For someone who loves to tell people to read the patch/bug submission
guidelines, you sure don't follow them.

- Derek