[FFmpeg-devel] [PATCH]Avoid an assertion failure in ff_init_vlc_sparse

Derek Buitenhuis derek.buitenhuis at gmail.com
Sat Jul 13 01:32:10 CEST 2013


On 7/12/2013 3:13 PM, Carl Eugen Hoyos wrote:
> -        av_assert0(ret >= 0);
> +        if (ret < 0)
> +            return ret;

... No.

This is not what assertions are for, and this is a hack.

The root cause should be determined. Furthermore, simply returning
ret seems pretty damn dangerous and filled with consequences for
codecs which use it.

- Derek


More information about the ffmpeg-devel mailing list