[FFmpeg-devel] [PATCH 3/5] ff_network_wait_fd_timeout(): check for interrupt before operation

Andrey Utkin andrey.krieger.utkin at gmail.com
Fri Jul 12 19:53:45 CEST 2013


2013/7/12 Lukasz M <lukasz.m.luki at gmail.com>:
> So far all you described was done internally. TCP could be used as
> black box. There was an API to break a loop, end of story,
> For me getting descriptor and polling it would break modulatiry and
> duplicates code.
> Your commit changes that logic and I pointed it to discuss it. I think
> that's the idea of community.
> And I really don't see a reason to discuss FTP protocol here and all
> your doubs about it, because there was a time for it when I submitted
> it.

I didn't mean to offend you.
We discuss your code because you mentioned it as an application for
further enhancements of interrupt feature.
My point is that you misuse the interrupt feature (and depend on
undocumented implementation details). It is originally meant for
immediate termination of stream processing, and that is the only thing
it is guaranteed to do well. Although it is not worded anywhere in
documentation; If i am wrong here, let more experienced developers
correct me.

--
Andrey Utkin


More information about the ffmpeg-devel mailing list