[FFmpeg-devel] [PATCH] lavf/segment: add initial_offset option

[Stefano Sabatini]

On date Saturday 2013-07-06 14:41:50 +0200, Stefano Sabatini encoded:
> On date Saturday 2013-07-06 14:31:31 +0200, Michael Niedermayer encoded:
> > On Sat, Jul 06, 2013 at 12:16:08PM +0200, Stefano Sabatini wrote:
> > > Should address trac ticket #2224.
> > > ---
> > >  doc/muxers.texi       |  4 ++++
> > >  libavformat/segment.c | 14 +++++++++-----
> > >  2 files changed, 13 insertions(+), 5 deletions(-)
> > 
> > if thats whats needed to fix the issue, then sure ok
> 
> I'll push as soon as the ticket reporter will confirm it.
>  
> > [...]
> > > @@ -793,6 +796,7 @@ static const AVOption options[] = {
> > >      { "individual_header_trailer", "write header/trailer to each segment", OFFSET(individual_header_trailer), AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, E },
> > >      { "write_header_trailer", "write a header to the first segment and a trailer to the last one", OFFSET(write_header_trailer), AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, E },
> > >      { "reset_timestamps", "reset timestamps at the begin of each segment", OFFSET(reset_timestamps), AV_OPT_TYPE_INT, {.i64 = 0}, 0, 1, E },
> > > +    { "initial_offset", "set initial offset in seconds", OFFSET(initial_offset), AV_OPT_TYPE_DURATION, {.i64 = 0}, -INT64_MAX, INT64_MAX, E },
> > 
> > is it really intended to be in seconds ?
> 
> It's a time duration specification, locally amended.
>  
> > also if fixing the issue requires a offset > 0 then this maybe should
> > becoe default at some point in the future
> 
> It's more an issue related to Apple HLS validation, which doesn't make
> much sense in the general case and thus should not be enabled by
> default (segment is a generic segmenter, should not be biased towards
> HLS).

Applied, TFTR.
-- 
FFmpeg = Forgiving Fundamentalist Mastering Portentous Efficient Game