[FFmpeg-devel] [RFC] estimate_timings_from_pts() ignores AVERROR_EXIT

Andrey Utkin andrey.krieger.utkin at gmail.com
Sun Jul 7 20:15:46 CEST 2013


You can test it using a code snippet which i attach, and this patch:
http://ffmpeg.org/pipermail/ffmpeg-devel/2013-July/145566.html
I've generated a test file in such way:
ffmpeg -f lavfi -i testsrc -t 1:00:00 -vcodec libx264 test.ts
In the code i've set up an interrupt check callback handler which
generally returns 1 when counted down variable gets below 0, and
prints this variable value. From this printouts i found out that
interrupt checker is invoked several times after 1 is returned.

With gdb i found that estimate_timings_from_pts() is the problem.
It has such fragment, if (ret != 0) break; which is meant to interrupt
the processing in case of some problems. But there are two nested
loops above this statement, and more file operations in the function
after these loops.
I feel not enough competent to make up fix by myself, at last without
consulting. So dear all, please comment.

--
Andrey Utkin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: exit_request_ignored.c
Type: text/x-csrc
Size: 1272 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130707/2069c27e/attachment.bin>


More information about the ffmpeg-devel mailing list