[FFmpeg-devel] [PATCH 1/2 v2] delogo: Use weighted interpolation

Jean Delvare khali at linux-fr.org
Mon Jul 1 13:43:48 CEST 2013


Hi Stefano,

On Mon, 1 Jul 2013 09:39:20 +0200, Stefano Sabatini wrote:
> On date Thursday 2013-06-27 23:12:45 +0200, Stefano Sabatini encoded:
> > On date Wednesday 2013-06-26 14:50:37 +0200, Jean Delvare encoded:
> > > The original delogo algorithm interpolates both horizontally and
> > > vertically and uses the average to compute the resulting sample. This
> > > works reasonably well when the logo area is almost square. However
> > > when the logo area is significantly larger than high or higher than
> > > large, the result is largely suboptimal.
> [...]
> > 
> > LGTM and nice idea.
> > 
> > Another possibility would be to consider generalized barycentric
> > coordinates with respect to the logo rectangle vertexes, but this
> > would be a completely different algorithm.
> > 
> > I assume that the algorithm has been tested, and will push it in a day
> > (or let Michael push it) if there are no other comments.
> 
> Pushed.

Thank you. For the record, I have instrumented the delogo filter to
measure the difference between the original picture and the
reconstructed picture (in the absence of actual logo, of course), and
this patch you just pushed reduces that difference by 5% to 9% in my
tests on cartoon video, and 24% in my tests on a regular movie.

So it definitely improved the quality in a proven way.

-- 
Jean Delvare


More information about the ffmpeg-devel mailing list