[FFmpeg-devel] [PATCH]Fix default stream flag value wrt matroska muxing

Carl Eugen Hoyos cehoyos at ag.or.at
Wed Jan 30 10:40:57 CET 2013


Hendrik Leppkes <h.leppkes <at> gmail.com> writes:

> >> and if none have a default disposition, then mark
> >> the first of each type as such (first audio, first video, first
> >> subtitle).
> >
> > This may be sensible, but is imo unrelated.

> Maybe it would be better to always write 0, even if no default exists?
> Otherwise all streams are marked as default because of the implicit
> default flag if its not written, not sure thats desirable?

I really have no opinion on this, I simply don't 
know the use-cases...

> I'll leave that to you, the solution looks otherwise 
> good to me, no side-effects bleeding into other parts 
> of avformat, which was my main concern.

Patch applied, if somebody wants to change the current 
behaviour to one of your suggestions, it should be easy.

Thank you, Carl Eugen



More information about the ffmpeg-devel mailing list