[FFmpeg-devel] [PATCH 2/3] lavc/dnxhddata: check profile frame_rate in ff_dnxhd_get_cid_table

[Michael Niedermayer]

On Tue, Jan 29, 2013 at 09:16:27AM +0100, Matthieu Bouron wrote:
> On Sat, Jan 26, 2013 at 12:46:00PM +0100, Matthieu Bouron wrote:
> > ---
> >  libavcodec/dnxhddata.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/dnxhddata.c b/libavcodec/dnxhddata.c
> > index 71cb333..a53aeb6 100644
> > --- a/libavcodec/dnxhddata.c
> > +++ b/libavcodec/dnxhddata.c
> > @@ -1057,7 +1057,8 @@ int ff_dnxhd_find_cid(AVCodecContext *avctx, int bit_depth)
> >              cid->interlaced == !!(avctx->flags & CODEC_FLAG_INTERLACED_DCT) &&
> >              cid->bit_depth == bit_depth) {
> >              for (j = 0; j < FF_ARRAY_ELEMS(cid->bit_rates); j++) {
> > -                if (cid->bit_rates[j] == mbs)
> > +                if (cid->bit_rates[j] == mbs &&
> > +                    !av_cmp_q(cid->frame_rates[j], av_inv_q(avctx->time_base)))
> >                      return cid->cid;
> >              }
> >          }
> 
> Ping

i suspect this will make the code fail if the framerate is slightly
off 2997/100 is popular in mov/qt
is that intended ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130129/6772ee22/attachment.asc>