[FFmpeg-devel] [RFC][PATCH 3/3] tta: Add support for encrypted streams

[Michael Niedermayer]

On Mon, Jan 28, 2013 at 04:32:54AM -0300, James Almer wrote:
> The code to decrypt data is added to the decoder, and
> the code needed to provide the decrypt key is added
> to the TTA demuxer.
>
> Any other container that supports TTA streams will
> need extra code to process the password and send it
> to the decoder using packet side data (main extradata
> is used for the TTA header).

why is the password handling split between demuxer and decoder ?


[...]

> @@ -44,7 +45,7 @@ typedef struct TTAFilter {
>      int32_t qm[MAX_ORDER];
>      int32_t dx[MAX_ORDER];
>      int32_t dl[MAX_ORDER];
> -} TTAFilter;
> +} DECLARE_ALIGNED(16, , TTAFilter);

this looks wrong
why do you try to align the struct ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130128/4ce1461a/attachment.asc>