[FFmpeg-devel] [PATCH] latmenc: Check for LOAS sync word

[Michael Niedermayer]

On Wed, Jan 16, 2013 at 05:25:03PM -0300, James Almer wrote:
> On 16/01/13 5:17 PM, Michael Niedermayer wrote:
> > If extradata is set then ADTS would be muxed into LATM creating a
> > invalid output
> > also the code is indented in a way that does not match the actual
> > relation of the statements
> 
> Encoders should not send ADTS packets with extradata. None currently does 
> either.

theres no need for a encoder, the input can come straight from a
container


> And i left indentation like that on purpose as other people asked me to
> do, to make the review easier (Leaving that for a cosmetic patch).
> 
> Do you want me to keep the ADTS check untouched and outside the extradata 
> check then?

yes

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130116/b690b84c/attachment.asc>