[FFmpeg-devel] [PATCH 02/10] lavfi: support unknown channel layouts.

[Nicolas George]

Le sextidi 16 nivôse, an CCXXI, Stefano Sabatini a écrit :
> here you could add:
> 
> // compute score in case the input or output layout encodes a channel count
> // in this case the score is not altered by the following code

Added something like that.

> Reminder: missing minor bump and APIchanges update in case this is a
> public interface.

I intend to add the minor bump and APIchanges entries as an additional
commit after the series is complete.

> channel_counts seems more consistent.

Changed like that.

> Micro bump/documentation update?

Added documentation update.

> slightly more explicative:
> "Neither number of channels nor channel layout was specified\n"

Changed.

> This code could make use of an audio check (and possibly work as
> default in case of video), so you get the expected result even with
> video, especially considering that there is nothing in the name
> suggesting that this only works with audio.

Ok.

> nit++++: remove the empty line while at it.

Done.

New patch series incoming when FATE finishes. Thanks for the review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130116/f5c04fb9/attachment.asc>