[FFmpeg-devel] [PATCH 3/3] lavd/v4l2: simplify return value checks

Carl Eugen Hoyos cehoyos at ag.or.at
Wed Jan 16 10:55:36 CET 2013


Stephan Hilb <stephan <at> ecshi.net> writes:

> >> -    fd = v4l2_open(ctx->filename, flags, 0);
> >> -    if (fd < 0) {
> >> +    if ((fd = v4l2_open(ctx->filename, flags, 0)) < 0) {
> > 
> > I fear one could say that it was decided yesterday that 
> > such changes are not welcome;-(
> 
> Alright, must've missed that. Is this a general rule?

No, just the opinion of one developer:
http://thread.gmane.org/gmane.comp.video.ffmpeg.cvs/59578/focus=59590

Carl Eugen



More information about the ffmpeg-devel mailing list