[FFmpeg-devel] [PATCH] doc/protocols: document http protocol options

Stefano Sabatini stefasab at gmail.com
Sat Jan 12 11:05:09 CET 2013


On date Friday 2013-01-11 18:46:08 +0100, Alexander Strasser encoded:
> Hi Stefano,
> 
> Stefano Sabatini wrote:
> > ---
> >  doc/protocols.texi |   36 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> > 
> > diff --git a/doc/protocols.texi b/doc/protocols.texi
> > index a36d2a3..e983341 100644
> > --- a/doc/protocols.texi
> > +++ b/doc/protocols.texi
> > @@ -128,6 +128,42 @@ m3u8 files.
> >  
> >  HTTP (Hyper Text Transfer Protocol).
> >  
> > +This protocol accepts the following options.
> > +
> > + at table @option
> > + at item seekable
> > +Control seekability of connection. If set to 1 the resource is
> > +supposed to be seekable, if set to 0 it is assumed not to be seekable,
> > +if set to -1 it will autodetect the seekability. Default value is 1.
> 
>   I think the default is -1.

Fixed.

> 
>   Maybe using "if set to -1 it will try to autodetect if it is seekable".
> IIRC autodetection fails for some servers, so using a more vague statement
> might encourage readers to try setting it to 1.

Fixed in a separate commit (forgot to fix it).
 
>   Despite that I find it a bit over the top to use the verb control this
> way. If I am not mistaken it just controls the treatment of the connection.
> Anyway, this is separate issue and should not be considered for this patch.

Yes, I'd prefer to keep it separated (I mostly adapted the code in the
option description).
 
[...] 
>   Looks ready to me if you looked at the rendered output.

Applied, thanks.
-- 
FFmpeg = Funny and Fantastic Mastering Portentous Elected Gospel


More information about the ffmpeg-devel mailing list