[FFmpeg-devel] [PATCH 01/10] ffmpeg: add -guess_layout_max option.

[Nicolas George]

Le sextidi 16 nivôse, an CCXXI, Stefano Sabatini a écrit :
> Alternatively we may just have -guess_layout, less generic but looks
> more straightforward.

You mean boolean? I had vaguely the intent, in the future, of lowering the
default from +\infty to 2, i.e. guess 1 channel = mono and 2 channels =
stereo but not beyond.

>			This way you could also move the check in the
> callee, and provide a more intelligible feedback.

I am not sure what you mean. The callee is a lavu utility function that can
not easily handle options.

> Nit: "set maximum...".

Fixed.

> I'm not the ffmpeg.c maintainer so better to wait for a reply from
> Michael.

Of course.

Thanks for the review. Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130105/4b0d255f/attachment.asc>