[FFmpeg-devel] [PATCH] lavfi: add histeq filter

Stefano Sabatini stefasab at gmail.com
Sat Jan 5 10:38:12 CET 2013


On date Friday 2013-01-04 16:42:10 +0100, Stefano Sabatini encoded:
> On date Friday 2013-01-04 16:19:07 +0100, Nicolas George encoded:
> > Le quintidi 15 nivôse, an CCXXI, Clement Boesch a écrit :
> > > > +                if (((m = FFMAX(r, FFMAX(g, b))) * lut) / luma > 255) {
> > > nit: I'm not sure the double expansion of the FFMAX macro will generate a
> > > sexy asm.
> > 
> > We have a FFMAX3 (but it does mostly the same thing).
> > 
> > > > +        .rej_perms        = AV_PERM_PRESERVE
> > > Is that necessary?
> > 
> > Since the permissions cleanup last summer, .rej_perms on inputs is usually
> > not useful.
> 
> Updated.
> 
> Will push tomorrow if I see no more comments.

Applied, thanks for the reviews.
-- 
FFmpeg = Fascinating and Fostering Miracolous Prodigious Esoteric Goblin


More information about the ffmpeg-devel mailing list