[FFmpeg-devel] [PATCH] alsdec: change channel sorting so it match reference implementation

[Paul B Mahol]

On 1/4/13, Thilo Borgmann <thilo.borgmann at googlemail.com> wrote:
> Am 04.01.13 17:39, schrieb Paul B Mahol:
>> On 1/4/13, Thilo Borgmann <thilo.borgmann at googlemail.com> wrote:
>>> Am 04.01.13 17:04, schrieb Paul B Mahol:
>>>> On 1/4/13, Thilo Borgmann <thilo.borgmann at googlemail.com> wrote:
>>>>> Am 04.01.13 15:09, schrieb Paul B Mahol:
>>>>>> On 1/3/13, Thilo Borgmann <thilo.borgmann at googlemail.com> wrote:
>>>>>>> Am 03.01.13 23:15, schrieb Thilo Borgmann:
>>>>>>>> Am 03.01.13 19:42, schrieb Paul B Mahol:
>>>>>>>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>>>>>>>> ---
>>>>>>>>>
>>>>>>>>> I did not thought that I need to test all permutations ;)
>>>>>>>>
>>>>>>>> Its another thing stored in the stream that lets me wonder for
>>>>>>>> which
>>>>>>>> files
>>>>>>>> this
>>>>>>>> could have worked before.
>>>>>>>>
>>>>>>>> This patch LGTM, please apply.
>>>>>>>
>>>>>>> Anyway you should change the log message to something more specific
>>>>>>> ;)
>>>>>>>
>>>>>>
>>>>>> What more specific? I don't have time to send multiple interations of
>>>>>> same patch so please say what log message for commit should be.
>>>>>
>>>>> "I did not thought that I need to test all permutations ;)" is not
>>>>> what
>>>>> is
>>>>> done
>>>>> in the patch and should therefore be more specific when committed.
>>>>
>>>> That line is not part of commit log.
>>>
>>> So there is none at all?
>>
>> Yes, if there should be one, please say what it should be.
>
> So if you innsist on it, how does "Read channel source instead of channel
> target
> for channel sorting." sound to you? Feel free to chose another comment if
> anything else fits your desires better than that but not none.

It is perfect for me.