[FFmpeg-devel] [PATCH] fate: disable globbing when calling shell functions.

Nicolas George nicolas.george at normalesup.org
Wed Jan 2 23:41:51 CET 2013


Some of the filters tests use globbing characters, especially
brackets for filter pad labels. While most of these strings
are way too complicated to ever match an existing file name
and are therefore kept unchanged in the command line (an old
misfeature of the shell language that happens to be convenient
here), at least one use is simple enough to match random files
lying in the current directory. If that happens, the string,
that was meant to be kept verbatim, is replaced by the file
name, and that causes the test to fail (or worse).

Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
---
 tests/fate-run.sh |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 9cd872b..0520d62 100755
--- a/tests/fate-run.sh
+++ b/tests/fate-run.sh
@@ -166,6 +166,10 @@ lavfitest(){
 
 mkdir -p "$outdir"
 
+# Disable globbing: command arguments may contain globbing characters and
+# must be kept verbatim
+set -f
+
 exec 3>&2
 eval $command >"$outfile" 2>$errfile
 err=$?
-- 
1.7.10.4



More information about the ffmpeg-devel mailing list