[FFmpeg-devel] [PATCH 02/10] lavfi: support unknown channel layouts.

[Nicolas George]

Le primidi 11 nivôse, an CCXXI, Stefano Sabatini a écrit :
> This is excluding lists supporting all channel layouts with a known
> disposition, and channel layouts with unknown disposition and a
> certain number N of channels, which could be represented as:
> 
> all_channels = 1;
> list = { FF_CHAN2LAYOUT(N) };
> 
> Another case: a list supporting all channel layouts with unknown
> disposition, but only a few with known disposition.
> 
> I wonder if this is by purpose. On the other hands such lists don't
> make much sense, but even in this case I wonder which are the
> pros/cons of adding more constraints.

I believe it would make the code slightly more complicated, the merge and
reduce part. It does not seem currently necessary, but if someone needs it
at some time, it should be possible to implement it then.

> I'll review the rest of the patch tomorrow.

Thanks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130101/7ed10ad6/attachment.asc>