[FFmpeg-devel] [PATCH 1/2] pmpdec: fix integer overflow

Michael Niedermayer michaelni at gmx.at
Mon Feb 25 16:56:37 CET 2013


On Mon, Feb 25, 2013 at 08:22:42AM +0000, Paul B Mahol wrote:
> On 2/24/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > Its unlikely this affects any valid files.
> >
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavformat/pmpdec.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/pmpdec.c b/libavformat/pmpdec.c
> > index 06b2271..3b8c5f7 100644
> > --- a/libavformat/pmpdec.c
> > +++ b/libavformat/pmpdec.c
> > @@ -93,7 +93,7 @@ static int pmp_header(AVFormatContext *s)
> >      avio_skip(pb, 10);
> >      srate = avio_rl32(pb);
> >      channels = avio_rl32(pb) + 1;
> > -    pos = avio_tell(pb) + 4*index_cnt;
> > +    pos = avio_tell(pb) + 4LL*index_cnt;
> >      for (i = 0; i < index_cnt; i++) {
> >          uint32_t size = avio_rl32(pb);
> >          int flags = size & 1 ? AVINDEX_KEYFRAME : 0;
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> 
> lgtm

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130225/c4de9e23/attachment.asc>


More information about the ffmpeg-devel mailing list