[FFmpeg-devel] [PATCH] lavfi/ebur128: fix format negociation for output.

[Nicolas George]

Le quintidi 5 ventôse, an CCXXI, Clement Boesch a écrit :
> ---
>  libavfilter/f_ebur128.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c
> index 66cc133..4a41458 100644
> --- a/libavfilter/f_ebur128.c
> +++ b/libavfilter/f_ebur128.c
> @@ -691,22 +691,6 @@ static int query_formats(AVFilterContext *ctx)
>          outlink = ctx->outputs[1];
>      }
>  
> -    /* set audio output formats (same as input since it's just a passthrough) */
> -    formats = ff_make_format_list(sample_fmts);
> -    if (!formats)
> -        return AVERROR(ENOMEM);
> -    ff_formats_ref(formats, &outlink->in_formats);
> -
> -    layouts = ff_all_channel_layouts();
> -    if (!layouts)
> -        return AVERROR(ENOMEM);
> -    ff_channel_layouts_ref(layouts, &outlink->in_channel_layouts);
> -
> -    formats = ff_make_format_list(input_srate);
> -    if (!formats)
> -        return AVERROR(ENOMEM);
> -    ff_formats_ref(formats, &outlink->in_samplerates);
> -
>      return 0;
>  }
>  
> @@ -745,7 +729,6 @@ static const AVFilterPad ebur128_inputs[] = {
>      {
>          .name             = "default",
>          .type             = AVMEDIA_TYPE_AUDIO,
> -        .get_audio_buffer = ff_null_get_audio_buffer,
>          .filter_frame     = filter_frame,
>      },
>      { NULL }

Can you explain why just removing all this code "fix"es anything? Possibly
in the commit message.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130224/6f515b08/attachment.asc>