[FFmpeg-devel] [PATCH] Fix Win64 AVX h264_deblock by not using redzone on Win64

Matthew Wolenetz wolenetz at chromium.org
Thu Feb 21 01:21:16 CET 2013


This patch fixes an issue encountered downstream in Chromium on Win64 on at
least AVX.  Win64, unlike other x64, does not allow usage of redzone in its
ABI.  h264_deblock.asm included indiscriminate usage of redzone on x86_64,
causing Access Violations on win64 chromium.

I attempted to repro the issue in win64 fate-h264 on ffmpeg HEAD, but none
of those tests appear to have failed.  After applying the patch, none of
the fate regression tests failed on win64.

Note: Thanks go to rbultje@ for providing the patch.

Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-Win64-AVX-h264_deblock-by-not-using-redzone-on-W.patch
Type: application/octet-stream
Size: 1264 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130220/4990b3c2/attachment.obj>


More information about the ffmpeg-devel mailing list